[
https://issues.apache.org/jira/browse/LUCENE-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049460#comment-13049460
]
Uwe Schindler edited comment on LUCENE-3201 at 6/14/11 10:07 PM:
-----------------------------------------------------------------
Robert: Very nice. Small thing:
- NIOFSCompoundFileDirectory / SimpleFSCompoundFileDirectory /
MMapCompoundFileDirectory are non-static inner classes but still get parent
Directory in ctor. This is douplicated as javac also passes the parent around
(the special ParentClassName.this one). I would remove the ctor param and use
"*FSDirectory.this" as reference to outer class. I nitpick, because at some
places it references the parent directory without the ctor param, so its
inconsistent.
That's all for now, thanks for hard work!
was (Author: thetaphi):
Robert: Very nice. Small thing:
- NIOFSCompoundFileDirectory / SimpleFSCompoundFileDirectory are non-static
inner classes but still get parent Directory in ctor. This is douplicated as
javac also passes the parent around (the special ParentClassName.this one). I
would remove the ctor param and use "Simple/NIO-FSDirectory.this" as reference
to outer class. I nitpick, because at some places it references the parent
directory without the ctor param, so its inconsistent.
That's all for now, thanks for hard work!
> improved compound file handling
> -------------------------------
>
> Key: LUCENE-3201
> URL: https://issues.apache.org/jira/browse/LUCENE-3201
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Robert Muir
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3201.patch, LUCENE-3201.patch
>
>
> Currently CompoundFileReader could use some improvements, i see the following
> problems
> * its CSIndexInput extends bufferedindexinput, which is stupid for
> directories like mmap.
> * it seeks on every readInternal
> * its not possible for a directory to override or improve the handling of
> compound files.
> for example: it seems if you were impl'ing this thing from scratch, you would
> just wrap the II directly (not extend BufferedIndexInput,
> and add compound file offset X to seek() calls, and override length(). But of
> course, then you couldnt throw read past EOF always when you should,
> as a user could read into the next file and be left unaware.
> however, some directories could handle this better. for example MMapDirectory
> could return an indexinput that simply mmaps the 'slice' of the CFS file.
> its underlying bytebuffer etc naturally does bounds checks already etc, so it
> wouldnt need to be buffered, not even needing to add any offsets to seek(),
> as its position would just work.
> So I think we should try to refactor this so that a Directory can customize
> how compound files are handled, the simplest
> case for the least code change would be to add this to Directory.java:
> {code}
> public Directory openCompoundInput(String filename) {
> return new CompoundFileReader(this, filename);
> }
> {code}
> Because most code depends upon the fact compound files are implemented as a
> Directory and transparent. at least then a subclass could override...
> but the 'recursion' is a little ugly... we could still label it
> expert+internal+experimental or whatever.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
