Yonik's law of patches states: "A half-baked patch in Jira, with no documentation, no tests and no backwards compatibility is better than no patch at all."
and what you've described sounds waaaay better than that! Anyway, I doubt you'll *ever* find someone on the dev list *complain* about opening up a JIRA on something when you're willing to attach a patch, especially one with unit tests.... Although you might have to nudge people to follow up on it... Best Erick On Tue, Jun 14, 2011 at 9:50 PM, Michael Sokolov <soko...@ifactory.com> wrote: > I work with a lot of XML data sources and have needed to implement an > analysis chain for Solr/Lucene that accepts XML. In the course of doing > that, I found I needed something very much like HTMLCharFilter, but that > does standard XML parsing (understands XML entities defined in an internal > or external DTD, for example). So I wrote XmlCharFilter, which uses the > Woodstox XML parser (already used by Solr). I think this could be useful > for others, and it would be nice for me if it were committed here, so I'd > like to contribute. Should I open a JIRA for this? Is there anybody that > can spare the time to review? It is basically one class (plus a factory > class) and has a fairly complete set of tests. > > -Mike Sokolov > Engineering Directory > iFactory.com > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
