[ 
https://issues.apache.org/jira/browse/LUCENE-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Woodward updated LUCENE-8017:
----------------------------------
    Attachment: LUCENE-8017.patch

Here's a patch adding getCacheHelper() as a method on Weight.  I've made this 
abstract and implemented it on all Weights - it could theoretically default to 
returning null or the Reader-level cache helper, but I think it's better to be 
explicit about it.

Some things to explore in follow-up issues:
* re-instate getCoreAndDeletesCacheHelper (or CoreAndDocValues, or whatever we 
want to call it) so that doc-values based queries can be re-used between 
searchers if the DV gen is the same
* add getCacheHelper to Double/LongValuesSource so that, eg constant DVS 
queries can be cached properly

> FunctionRangeQuery and FunctionMatchQuery can pollute the QueryCache
> --------------------------------------------------------------------
>
>                 Key: LUCENE-8017
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8017
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>         Attachments: LUCENE-8017.patch
>
>
> The QueryCache assumes that queries will return the same set of documents 
> when run over the same segment, independent of all other segments held by the 
> parent IndexSearcher.  However, both FunctionRangeQuery and 
> FunctionMatchQuery can select hits based on score, which depend on term 
> statistics over the whole index, and could therefore theoretically return 
> different result sets on a given segment.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to