[ 
https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241900#comment-16241900
 ] 

Robert Muir commented on LUCENE-8038:
-------------------------------------

They need to be restricted though, thats why we opened this issue, because we 
are working on fixing similarity impls to have well-defined behavior, so that 
we can have these optimizations.

For example a similarity should never be asked to compute tf(0), it will result 
in divide by zero with most scoring systems. Its not something we should have 
to guard against with conditionals everywhere, it should instead be avoided.

> Decouple payload decoding from Similarity
> -----------------------------------------
>
>                 Key: LUCENE-8038
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8038
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>         Attachments: LUCENE-8038-master.patch, LUCENE-8038.patch
>
>
> PayloadScoreQuery is the only place that currently uses 
> SimScorer.computePayloadFactor(), and as discussed on LUCENE-8014, this seems 
> like the wrong place for it.  We should instead add a PayloadDecoder 
> abstraction that is passed to PayloadScoreQuery.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to