[ 
https://issues.apache.org/jira/browse/SOLR-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242439#comment-16242439
 ] 

David Smiley commented on SOLR-11380:
-------------------------------------

Ah; much clearer!
* I suppose 
{{org.apache.solr.client.solrj.request.RequestWriter#getContentStreams}} should 
also be deprecated?
* Did you try to implement RequestWriter.getContentWriter in terms of a 
getContentStreams if the latter was provided?  It'd be great if that were 
possible as it would greatly simplify 
{{org.apache.solr.client.solrj.impl.HttpSolrClient#createMethod}} which calls 
both. That said, perhaps it's not easy and needs to be punted until 8.0.
* You removed the getter of content streams from GenericSolrRequest but I think 
it should stay for this class?  There's certainly something wrong if the setter 
stays without the getter.

> SolrJ must stream docs to server instead of writing to a byte[] first 
> ----------------------------------------------------------------------
>
>                 Key: SOLR-11380
>                 URL: https://issues.apache.org/jira/browse/SOLR-11380
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 7.2, master (8.0)
>
>         Attachments: SOLR-11380.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to