Hi Uwe,
Thanks for the update.
I suggest you give feedback to Mark re:versioning etc on mailing list
Thanks,Rory
On 05/11/2017 11:01, Uwe Schindler wrote:
Hi Rory, hi all,
after adding a call to a new „assumeWorkingMockito()“ to Solr’s tests
that use Mockito (see
https://issues.apache.org/jira/browse/SOLR-11606) all of our tests
pass as they did with Java 9. No further problems with JDK 10.
The new versioning scheme as proposed by Mark is fine to us, but the
problems with Mockito show, that there might me the need to make it
easier for byte-code processing APIs like ASM or ByteBuddy (or my own
forbiddenapis) to keep track of new versions. Maybe it’s better to
only raise the bytecode version numbers when something changes in
bytecode. Once we have a solution and spec for this, we can hope that
the bytecode tools like ASM, cglib, BCEL, ByteBuddy have a clear way
to proceed with releases. My proposal would be to use the bytecode
minor number, too (the CLASS file format has a major and a minor
number, but only the major number is used since java 1.0, the other
one was always zero), so we have a more semantic versioning. E.g. if
the minor number changes, an existing parser should be able to parse
the bytecode successfully, if he is prepared to read over unknown
attributes. On the other hand if really new opcodes or data types like
value types were added, the major version should be incremented – as
that would break parsing of files completely.
Uwe
-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
http://www.thetaphi.de <http://www.thetaphi.de/>
eMail: [email protected]
*From:*Uwe Schindler [mailto:[email protected]]
*Sent:* Friday, November 3, 2017 11:48 PM
*To:* [email protected]; [email protected]
*Cc:* 'Dalibor Topic' <[email protected]>; 'Balchandra Vaidya'
<[email protected]>; 'Muneer Kolarkunnu'
<[email protected]>
*Subject:* RE: JDK 10 b29 Early Access is available on jdk.java.net
Hi,
In general, Java 10 preview build works correct. All Lucene tests work
correctly.
But we have a problem with Mockito's Bytebuddy. The Mocking framework
throws an Exception if it detects Java 10. I opened a bug report:
https://github.com/raphw/byte-buddy/issues/370
For now I disabled the Java 10 tests. I will add an assume to the
Mockito-based tests, so they are disabled, if the Bytebuddy method
throws an Exception (can be done by a simple check). I will take care
tomorrow.
Rory, I will come back to you once I added an workaround for the usage
of Mocking frameworks.
Uwe
-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
http://www.thetaphi.de <http://www.thetaphi.de/>
eMail: [email protected] <mailto:[email protected]>
*From:*Rory O'Donnell [mailto:[email protected]]
*Sent:* Friday, November 3, 2017 5:10 PM
*To:* [email protected] <mailto:[email protected]>; Uwe
Schindler <[email protected] <mailto:[email protected]>>;
[email protected] <mailto:[email protected]>
*Cc:* [email protected] <mailto:[email protected]>;
'Dalibor Topic' <[email protected]
<mailto:[email protected]>>; 'Balchandra Vaidya'
<[email protected] <mailto:[email protected]>>;
'Muneer Kolarkunnu' <[email protected]
<mailto:[email protected]>>
*Subject:* Re: JDK 10 b29 Early Access is available on jdk.java.net
Thanks Uwe, looking forward to your report !
Rgds,Rory
On 03/11/2017 15:23, Uwe Schindler wrote:
Hi Rory,
I just came back from J-Fall 2017. Thanks for the update about new
EA builds! I was waiting for it, and now I can try it out, cool. I
will report back soon, once I added JDK 10 to our Jenkins Cluster.
We are happy to see the new version numbering proposal that uses
the usual major.minor pattern, counting from 10 onwards instead of
the year-month style; Dalibor and I discussed about it on our
train ride today! When testing the new builds, I hope this time
nothing breaks because the main version number has suddenly 2
digits 😊.
Uwe
-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
http://www.thetaphi.de <http://www.thetaphi.de/>
eMail: [email protected] <mailto:[email protected]>
*From:*Rory O'Donnell [mailto:[email protected]]
*Sent:* Friday, November 3, 2017 10:48 AM
*To:* [email protected]
<mailto:[email protected]>; [email protected]
<mailto:[email protected]>
*Cc:* [email protected] <mailto:[email protected]>;
Dalibor Topic <[email protected]>
<mailto:[email protected]>; Balchandra Vaidya
<[email protected]>
<mailto:[email protected]>; Muneer Kolarkunnu
<[email protected]>
<mailto:[email protected]>; [email protected]
<mailto:[email protected]>
*Subject:* JDK 10 b29 Early Access is available on jdk.java.net
Hi Uwe & Dawid,
JDK 10 Early Access build 29 is available at : - jdk.java.net/10/
JDK 10 Early Access Release Notes are available [1]
JDK 10 Schedule, Status & Features are available [2]
Notes
* OpenJDK EA binaries will be available at a later date.
* Oracle has proposed: Newer version-string scheme for the Java
SE Platform and the JDK
o Please see Mark Reinhold's proposal [3] , feedback via the
mailing list to Mark please.
Feedback - If you have suggestions or encounter bugs, please
submit them using the usual Java SE bug-reporting channel.
Be sure to include complete version information from the output of
the |java --version| command.
Regards,
Rory
[1] http://jdk.java.net/10/release-notes
[2] http://openjdk.java.net/projects/jdk/10/
[3]
http://mail.openjdk.java.net/pipermail/jdk-dev/2017-November/000089.html
--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland
--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland
--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland
