[ 
https://issues.apache.org/jira/browse/LUCENE-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246738#comment-16246738
 ] 

Steve Rowe commented on LUCENE-8014:
------------------------------------

{{git bisect}} blames the {{946ec9d5b94}} commit on this issue for the 2 
following reproducing failures from 
[https://jenkins.thetaphi.de/job/Lucene-Solr-master-MacOSX/4281/]:

{noformat}
   [junit4] Suite: org.apache.lucene.search.spans.TestSpans
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestSpans 
-Dtests.method=testSpanScorerZeroSloppyFreq -Dtests.seed=4FC38F5EE84A65AB 
-Dtests.slow=true -Dtests.locale=no -Dtests.timezone=Etc/GMT-14 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
   [junit4] FAILURE 0.03s J0 | TestSpans.testSpanScorerZeroSloppyFreq <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: first doc score should 
be zero, 3.0794418
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([4FC38F5EE84A65AB:73B03B755EA850AC]:0)
   [junit4]    >        at 
org.apache.lucene.search.spans.TestSpans.testSpanScorerZeroSloppyFreq(TestSpans.java:320)
   [junit4]    >        at java.lang.Thread.run(Thread.java:748)
   [junit4]   2> NOTE: test params are: codec=Asserting(Lucene70), 
sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@44515136),
 locale=no, timezone=Etc/GMT-14
   [junit4]   2> NOTE: Mac OS X 10.11.6 x86_64/Oracle Corporation 1.8.0_144 
(64-bit)/cpus=3,threads=1,free=116775256,total=317194240
{noformat}

{noformat}
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestSimilarity 
-Dtests.method=testSimilarity -Dtests.seed=4FC38F5EE84A65AB -Dtests.slow=true 
-Dtests.locale=pt-BR -Dtests.timezone=Europe/Ulyanovsk -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
   [junit4] FAILURE 0.02s J1 | TestSimilarity.testSimilarity <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: expected:<2.0> but 
was:<1.0>
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([4FC38F5EE84A65AB:BE6CCF66E8AAF0B0]:0)
   [junit4]    >        at 
org.apache.lucene.search.TestSimilarity$4.collect(TestSimilarity.java:146)
   [junit4]    >        at 
org.apache.lucene.search.AssertingLeafCollector.collect(AssertingLeafCollector.java:52)
   [junit4]    >        at 
org.apache.lucene.search.AssertingCollector$1.collect(AssertingCollector.java:56)
   [junit4]    >        at 
org.apache.lucene.search.AssertingLeafCollector.collect(AssertingLeafCollector.java:52)
   [junit4]    >        at 
org.apache.lucene.search.Weight$DefaultBulkScorer.scoreAll(Weight.java:293)
   [junit4]    >        at 
org.apache.lucene.search.Weight$DefaultBulkScorer.score(Weight.java:236)
   [junit4]    >        at 
org.apache.lucene.search.BulkScorer.score(BulkScorer.java:39)
   [junit4]    >        at 
org.apache.lucene.search.AssertingBulkScorer.score(AssertingBulkScorer.java:69)
   [junit4]    >        at 
org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:645)
   [junit4]    >        at 
org.apache.lucene.search.AssertingIndexSearcher.search(AssertingIndexSearcher.java:72)
   [junit4]    >        at 
org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:449)
   [junit4]    >        at 
org.apache.lucene.search.TestSimilarity.testSimilarity(TestSimilarity.java:137)
   [junit4]    >        at java.lang.Thread.run(Thread.java:748)
   [junit4]   2> NOTE: test params are: codec=Asserting(Lucene70): 
{field=PostingsFormat(name=Memory)}, docValues:{}, maxPointsInLeafNode=1240, 
maxMBSortInHeap=5.9146841525724625, 
sim=Asserting(org.apache.lucene.search.similarities.AssertingSimilarity@2e5f1dd1),
 locale=pt-BR, timezone=Europe/Ulyanovsk
   [junit4]   2> NOTE: Mac OS X 10.11.6 x86_64/Oracle Corporation 1.8.0_144 
(64-bit)/cpus=3,threads=1,free=258508624,total=309329920
{noformat}

> Remove SimScorer.computeSlopFactor and SimScorer.computePayloadFactor
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-8014
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8014
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: master (8.0), 7.2
>
>         Attachments: LUCENE-8014.patch
>
>
> This supersedes LUCENE-8013.
> We should hardcode computeSlopFactor to 1/(N+1) in SloppyPhraseScorer and 
> move computePayloadFactor to PayloadFunction so that all the payload scoring 
> logic is in a single place.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to