[ https://issues.apache.org/jira/browse/SOLR-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050677#comment-13050677 ]
Martijn van Groningen commented on SOLR-2564: --------------------------------------------- I also did some performance tests with the following query on random data in the example schema: {code}http://localhost:8983/solr/select?q=*:*&sort=_docid_ desc&group=true&group.cacheMB=0&group.field=single1000_i{code} The field single1000_i had 1000 distinct values and the index has in total 100000 documents. I ran this query on the following Solr setups: * Last nights nightly build. * Solr build with this patch as it is. * Solr build with this patch and the necessary changes in AbstractFirstPassGroupingCollector so that pollLast was used in all cases. During my tests I noticed that differences between the first and the second setups was neglectable smal, but the the last Solr setup was on average 32% faster than the two other setups. So moving to the Java6's pollLast() method has definitely a positive impact on performance! I also think that this patch is ready to be committed and that the pollLast should be added when Lucene or the grouping module is java 6. (I prefer the first option) I'll commit it in the coming day or so. > Integrating grouping module into Solr 4.0 > ----------------------------------------- > > Key: SOLR-2564 > URL: https://issues.apache.org/jira/browse/SOLR-2564 > Project: Solr > Issue Type: Improvement > Reporter: Martijn van Groningen > Assignee: Martijn van Groningen > Priority: Blocker > Fix For: 4.0 > > Attachments: LUCENE-2564.patch, SOLR-2564.patch, SOLR-2564.patch, > SOLR-2564.patch, SOLR-2564.patch, SOLR-2564.patch, SOLR-2564.patch, > SOLR-2564.patch > > > Since work on grouping module is going well. I think it is time to wire this > up in Solr. > Besides the current grouping features Solr provides, Solr will then also > support second pass caching and total count based on groups. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org