[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250492#comment-16250492
]
Jason Gerlowski commented on SOLR-7871:
---------------------------------------
Thanks for giving this a look Shawn. I'll be working this evening on making
some of the changes you suggested, but wanted to answer a few questions in the
meantime.
bq. Unless we're going to switch the entire config system to yaml, I think it
would be a bad idea to introduce yaml configuration for this.
Agreed and well said.
bq. it looks like the decision is to go with a .conf file... it may be a
reasonable approach, though I think .properties may be better.
The name of the file is {{.conf}}, but it's actually prop-file syntax that's
used. In fact, the code uses the native Java support to parse and use the
config. So maybe we should pick a different extension/filename, but sounds
like we're in agreement on the format.
bq. it does look like there's no attempt to parse or convert an existing
solr.in.*
I think you just missed it at first glance. The attached patch still supports
{{solr.in.sh}} and {{solr.in.cmd}} files. For the Linux version, search for
the {{. "$SOLR_INCLUDE"}} in the patched {{bin/solr}}.
bq. it would be a good idea to move a lot more of what the solr script does
into SolrCLI, including parsing the platform-independent config file
If I understand your suggestion correctly, the current patch already does this.
See {{SolrConfigCreator.java}}. If you've got something else in mind, or can
see a way to have even less bash/batch logic though, I'm all for it.
> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
> Key: SOLR-7871
> URL: https://issues.apache.org/jira/browse/SOLR-7871
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 5.2.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Labels: bin/solr
> Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable
> batch files, but all they do is to set environment variables for the start
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g.
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by
> {{SolrCLI.java}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
