[
https://issues.apache.org/jira/browse/LUCENE-8049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259485#comment-16259485
]
Adrien Grand commented on LUCENE-8049:
--------------------------------------
+1 Should we also wrap with a {{Collections.unmodifiableSet}} to prevent
callers from modifying IndexWriter's state?
> IndexWriter.getMergingSegments should return a Set, not Collection
> ------------------------------------------------------------------
>
> Key: LUCENE-8049
> URL: https://issues.apache.org/jira/browse/LUCENE-8049
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
>
> IndexWriter.getMergingSegments is called by the MergePolicy so that it can
> filter out segments to merge using mergingSegments.contains(seg). The
> implementation is a HashSet, thankfully but the declared type of this method
> ought to be defined as a Set as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
