[ https://issues.apache.org/jira/browse/LUCENE-8060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263175#comment-16263175 ]
Shai Erera commented on LUCENE-8060: ------------------------------------ What if we conceptually remove {{TopDocs.totalHits}} and if users require that, they can chain their Collector with {{TotalHitCountCollector}}? We can also add that boolean as a sugar to {{IndexSearcher.search()}} API. If we're OK w/ removing {{TopDocs.totalHits}}, and users getting a compilation error (that's easy to fix), then that's an easy option/change. Or... we deprecate it, but keep the simple IndexSearcher.search() APIs still compute it (by chaining this collector), and let users who'd like to optimize use the search() API which takes a Collector. Just a thought... > Require users to tell us whether they need total hit counts > ----------------------------------------------------------- > > Key: LUCENE-8060 > URL: https://issues.apache.org/jira/browse/LUCENE-8060 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Adrien Grand > Priority: Minor > Fix For: master (8.0) > > > We are getting optimizations when hit counts are not required (sorted > indexes, MAXSCORE, short-circuiting of phrase queries) but our users won't > benefit from them unless we disable exact hit counts by default or we require > them to tell us whether hit counts are required. > I think making hit counts approximate by default is going to be a bit trappy, > so I'm rather leaning towards requiring users to tell us explicitly whether > they need total hit counts. I can think of two ways to do that: either by > passing a boolean to the IndexSearcher constructor or by adding a boolean to > all methods that produce TopDocs instances. I like the latter better but I'm > open to discussion or other ideas? -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org