Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/275#discussion_r153109827
  
    --- Diff: 
solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java ---
    @@ -1794,6 +1798,37 @@ public void testOperatorsAndMultiWordSynonyms() 
throws Exception {
         );
       }
     
    +  public void testOverlapTermScoringQueries() throws Exception {
    +    ModifiableSolrParams edismaxParams = new ModifiableSolrParams();
    +    edismaxParams.add("qf", "t_pick_best_foo");
    +
    +    QParser qParser = QParser.getParser("tabby", "edismax", 
req(edismaxParams));
    +    Query q = qParser.getQuery();
    +    assertEquals("+((t_pick_best_foo:tabbi | t_pick_best_foo:cat | 
t_pick_best_foo:felin | t_pick_best_foo:anim))", q.toString());
    +
    +    edismaxParams = new ModifiableSolrParams();
    --- End diff --
    
    Solr tests have a `params()` method which is much more concise and doesn't 
pollute the variable namespace unnecessarily


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to