[ https://issues.apache.org/jira/browse/LUCENE-8008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271129#comment-16271129 ]
ASF subversion and git services commented on LUCENE-8008: --------------------------------------------------------- Commit d27ddcb409ddf5d388734db2428ac60edc22180a in lucene-solr's branch refs/heads/master from [~jpountz] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d27ddcb ] LUCENE-8008: Reduce leniency in CheckHits. > reduce/remove usages of CheckHits.EXPLAIN_TOLERANCE_* > ----------------------------------------------------- > > Key: LUCENE-8008 > URL: https://issues.apache.org/jira/browse/LUCENE-8008 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Robert Muir > Attachments: LUCENE-8008.patch > > > these tolerance deltas are being (ab)used in various ways in tests. I did > some experimentation and they can almost be removed entirely without too much > pain. > LUCENE-7997 fixes all similarities such that score() == explain(). It makes > its possible to actually debug numeric errors and we need to do that if we > have optimizations such as maxscore that care about score values. So I think > we should do the same thing elsewhere in scoring (weight/scorer). > We should at the very least fix tests (such as expression tests) that no > longer need these deltas and can now assert exact values. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org