[
https://issues.apache.org/jira/browse/LUCENE-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273271#comment-16273271
]
Karl Wright commented on LUCENE-8070:
-------------------------------------
[~ivera], I like the fix, but I'd move the following to PlanetModel as a method
of its own:
+ final double maxRadius =
Math.min(planetModel.surfaceDistance(planetModel.NORTH_POLE,
planetModel.SOUTH_POLE),
+ planetModel.surfaceDistance(planetModel.MIN_X_POLE,
planetModel.MAX_X_POLE));
Thanks!
> GeoExactCircle should not create circles that they do not fit in spheroid
> --------------------------------------------------------------------------
>
> Key: LUCENE-8070
> URL: https://issues.apache.org/jira/browse/LUCENE-8070
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Attachments: LUCENE-8070-test.patch, LUCENE-8070.patch
>
>
> Hi [~daddywri],
> I have seen test fail when we try to create circles that the don' t fit in
> the planet. I think sectors of the circle start overlapping to each other and
> the shape becomes invalid. The shape should prevent that to happen.
> I will attach a test and a proposed solution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
