[ 
https://issues.apache.org/jira/browse/LUCENE-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274607#comment-16274607
 ] 

Michael McCandless commented on LUCENE-8043:
--------------------------------------------

Thanks [~simonw]; I love the new assert, and the patch looks correct to me.

I beasted all Lucene tests 33 times and hit this failure, twice:

{noformat}
ant test -Dtestcase=TestIndexWriter -Dtestmethod=testThreadInterruptDeadlock 
-Dtests.seed=55197CA38E8C827B

java.lang.AssertionError: pendingNumDocs 0 != 11 totalMaxDoc
        at org.apache.lucene.index.IndexWriter.shutdown(IndexWriter.java:1277)
        at org.apache.lucene.index.IndexWriter.close(IndexWriter.java:1319)
        at 
org.apache.lucene.index.TestIndexWriter$IndexerThreadInterrupt.run(TestIndexWriter.java:902)
{noformat}

But it does not reproduce for me.

I hit two other unrelated failures; look like Similarity issues ... I'll open 
separate issues for those.

> Attempting to add documents past limit can corrupt index
> --------------------------------------------------------
>
>                 Key: LUCENE-8043
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8043
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 4.10, 7.0, master (8.0)
>            Reporter: Yonik Seeley
>            Assignee: Simon Willnauer
>             Fix For: master (8.0), 7.2, 7.1.1
>
>         Attachments: LUCENE-8043.patch, LUCENE-8043.patch, LUCENE-8043.patch, 
> LUCENE-8043.patch, YCS_IndexTest7a.java
>
>
> The IndexWriter check for too many documents does not always work, resulting 
> in going over the limit.  Once this happens, Lucene refuses to open the index 
> and throws a CorruptIndexException: Too many documents.
> This appears to affect all versions of Lucene/Solr (the check was first 
> implemented in LUCENE-5843 in v4.9.1/4.10 and we've seen this manifest in 
> 4.10) 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to