[ 
https://issues.apache.org/jira/browse/LUCENE-3220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052032#comment-13052032
 ] 

Robert Muir commented on LUCENE-3220:
-------------------------------------

oh two more nitpicky comments: 
* can you update the patch to use two-spaces instead of tabs? if you use 
eclipse, you can download this and configure this as your default codestyle: 
http://people.apache.org/~rmuir/Eclipse-Lucene-Codestyle.xml
* can you also remove the @author? For legal reasons (i think actually for your 
protection!) we omit these from new files.
* it might be a good idea to use the tag @lucene.experimental also for new 
classes: this is a template that 'ant-javadocs' replaces with "WARNING: This 
API is experimental and might change in incompatible ways in the next release." 
to tell users that its very new and not to expect precise backwards 
compatibility.


> Implement various ranking models as Similarities
> ------------------------------------------------
>
>                 Key: LUCENE-3220
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3220
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/search
>    Affects Versions: flexscoring branch
>            Reporter: David Mark Nemeskey
>            Assignee: David Mark Nemeskey
>              Labels: gsoc
>         Attachments: LUCENE-3220.patch, LUCENE-3220.patch
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> With [LUCENE-3174|https://issues.apache.org/jira/browse/LUCENE-3174] done, we 
> can finally work on implementing the standard ranking models. Currently DFR, 
> BM25 and LM are on the menu.
> TODO:
>  * {{EasyStats}}: contains all statistics that might be relevant for a 
> ranking algorithm
>  * {{EasySimilarity}}: the ancestor of all the other similarities. Hides the 
> DocScorers and as much implementation detail as possible
>  * _BM25_: the current "mock" implementation might be OK
>  * _LM_
>  * _DFR_
> Done:

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to