[
https://issues.apache.org/jira/browse/LUCENE-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052215#comment-13052215
]
Uwe Schindler commented on LUCENE-2548:
---------------------------------------
Hi Mike,
patch looks great, thanks for doing this hard work :-) PreFlexCodec looks fine,
see no problems there. Lucene code iterating TermsEnums was successfully
cleaned up (the lovely MTQs) from T.createTerm and equals added at some places.
I cannot check if there are comparisons missing, I wonder why PMD/Findbugs has
bugs that it does not find all occurences, maybe because some SuppressWarnings
also hiding those occurences? Can you explain shortly what "Unable to render
embedded object: File" has to do with interning?
Solr code is fine, I expected more to change. Some places in Solr still seems
to use some "placeholder" terms (called idTerm and other names). We should
maybe check if they are only field names in reality?
GREAT WORK! I AM SO HAPPY, dumdidumm...!
> Remove all interning of field names from flex API
> -------------------------------------------------
>
> Key: LUCENE-2548
> URL: https://issues.apache.org/jira/browse/LUCENE-2548
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Michael McCandless
> Fix For: 4.0
>
> Attachments: LUCENE-2548.patch, LUCENE-2548.patch
>
>
> In previous versions of Lucene, interning of fields was important to minimize
> string comparison cost when iterating TermEnums, to detect changes in field
> name. As we separated field names from terms in flex, no query compares field
> names anymore, so the whole performance problematic interning can be removed.
> I will start with doing this, but we need to carefully review some places
> e.g. in preflex codec.
> Maybe before this issue we should remove the Term class completely. :-)
> Robert?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
