[
https://issues.apache.org/jira/browse/SOLR-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-11754:
--------------------------------
Attachment: SOLR-11754.patch
Here's a patch.
I also removed SolrExampleTestBase (in SolrJ tests) whose only subclass is
MergeIndexesExampleTestBase and whose only subclass is
MergeIndexesEmbeddedTest. It's fairly generic but doesn't seem to add much
value. It was added in SOLR-5914 in 2014 by [[email protected]]. Mark,
perhaps you had bigger plans for SETB (given its generic name; appears very
broad in use) but apparently that didn't take shape. Are you good with
removing it?
Tests pass (well; some failed but were not related to any of these tests; I've
got lots of stuff going on right now).
> Remove AbstractSolrTestCase
> ---------------------------
>
> Key: SOLR-11754
> URL: https://issues.apache.org/jira/browse/SOLR-11754
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: David Smiley
> Assignee: David Smiley
> Attachments: SOLR-11754.patch
>
>
> I'm arguing AbstractSolrTestCase should be removed as it's obsoleted by
> SolrTestCaseJ4.
> In SOLR-3911 (back in 2012) Mark made it extend from SolrTestCaseJ4. There
> is really very little in this test class. Some of the methods here are
> duplicated by SolrTestCaseJ4 and thus are completely redundant
> (ignoreException, resetExceptionIgnores, getFile). There haven't been any
> modifications to this class of substance since 2012 either.
> I think we can just outright remove it (no deprecation phase). Anyone still
> using it can trivially switch.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
