[ 
https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294508#comment-16294508
 ] 

David Smiley commented on LUCENE-8099:
--------------------------------------

Oh, you're right of course about the dependency; I missed the "test" scope.

RE DoubleValueSource helper: which issue do you refer to?  I'd like to learn 
more.  I found LUCENE-7736 though the committed code does show that the lambdas 
/ "ReaderFunction" instances are in fact compared for equality in 
org.apache.lucene.queries.function.IndexReaderFunctions.IndexReaderDoubleValuesSource
   

I think score-multiplication is extremely common.  I like the utility method 
you did here for Solr but that's harder to do in Lucene land because it uses 
various modules (expressions + queries) that don't depend on each other.  If we 
were to reconsider adding more direct functionality for this, perhaps it might 
add no new _public_ classes -- just a static factory method on 
FunctionScoreQuery?  Something to consider.

> Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery
> ----------------------------------------------------------
>
>                 Key: LUCENE-8099
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8099
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-8099.patch
>
>
> After LUCENE-7998, these three queries can all be replaced by a 
> FunctionScoreQuery.  Using lucene-expressions makes them much easier to use 
> as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to