[
https://issues.apache.org/jira/browse/LUCENE-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309766#comment-16309766
]
Adrien Grand commented on LUCENE-8113:
--------------------------------------
I like the simplification of this patch, and agree it is better without
inheritance.
I like {{IndexTermStates}}, or maybe just {{TermStates}}?
Some comments:
* The ScoreMode changes look good to me.
* Can we avoid adding a new public constructor? I think it's already a bit bad
that it has 2 public constructors and 1 factory method.
* Add javadocs to explain what {{needsStats}} is about?
> Allow terms dictionary lookups to be lazy when scores are not needed
> --------------------------------------------------------------------
>
> Key: LUCENE-8113
> URL: https://issues.apache.org/jira/browse/LUCENE-8113
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Attachments: LUCENE-8113.patch, LUCENE-8113.patch
>
>
> LUCENE-7311 made it possible to avoid loading TermStates in cached
> TermQueries. It would be useful to extend this to other queries that use the
> terms dictionary.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
