[
https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313220#comment-16313220
]
David Smiley commented on LUCENE-8099:
--------------------------------------
The two additional convenience methods with backing value sources are fantastic
(thank you) -- it addresses my earlier concerns. it seems lightweight and
needn't involve another module (expressions). At the time I said this, you
responded to say this:
bq. DoubleValuesSource had a helper to create sources that used arbitrary
functions when I first committed it, but I removed it a bit later because it
messed up equality tests (essentially, you can't check Java closures for
equality).
Your latest commit doesn't show any changes to equality tests... are we talking
about different things? Was Hoss's "-1" what pushed you over to make these
changes? I'm wondering if I should give -1's more... I think I felt about as
strongly as Hoss but didn't express it.
> Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery
> ----------------------------------------------------------
>
> Key: LUCENE-8099
> URL: https://issues.apache.org/jira/browse/LUCENE-8099
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Fix For: 7.3
>
> Attachments: LUCENE-8099-2.patch, LUCENE-8099.patch, LUCENE-8099.patch
>
>
> After LUCENE-7998, these three queries can all be replaced by a
> FunctionScoreQuery. Using lucene-expressions makes them much easier to use
> as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
