[ https://issues.apache.org/jira/browse/LUCENE-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313287#comment-16313287 ]
Robert Muir commented on LUCENE-8119: ------------------------------------- I think we can see it does what we want via the assert: {code} assert state.getLength() > 0; {code} https://github.com/apache/lucene-solr/blob/master/lucene/test-framework/src/java/org/apache/lucene/search/similarities/AssertingSimilarity.java#L37 So it would be good to simplify the language, keeping in mind this method will never be called for empty fields. > Remove SimScorer.maxScore(maxFreq) > ---------------------------------- > > Key: LUCENE-8119 > URL: https://issues.apache.org/jira/browse/LUCENE-8119 > Project: Lucene - Core > Issue Type: Task > Reporter: Adrien Grand > Priority: Minor > Attachments: LUCENE-8119.patch > > > Now that SimScorer directly takes a frequency and a norm, this can be > replaced with {{SimScorer.freq(maxFreq, 1)}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org