(I had left the comment in question) I think a test shouldn't have to explicitly clean up after itself, except perhaps intra-method as-needed; test-infrastructure should do the class (test suite).
On Thu, Jan 11, 2018 at 12:49 PM Erick Erickson <erickerick...@gmail.com> wrote: > The recent failures in TimeRoutedAliasUpdateProcessorTest. are a result of > the changes to SOLR-11218. The initial fix is easy, but while fixing it I > saw a comment in there about cleaning up when tests.iters is specified > 1. > > The assumption was that everything would be cleaned up between runs > doesn't appear to be true for SolrCloud tests. I think one of two things is > happening: > > 1> collections (and perhaps aliases) are simply not cleaned up > > 2> there is a timing issue, we have waitForCollectionToDisappear in test > code after all. > > My question is what are the expectations? It's pretty ugly to require each > test to clean up all changes to ZooKeeper or else fail when test.iters is > set. Plus it violates the expectation that running one test doesn't affect > the other test, even if it's the same test over and over. > > So if we think it's an issue with the framework, any clues where to look > would be appreciated. > -- Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www.solrenterprisesearchserver.com
