Github user fsparv commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/304#discussion_r161155263
--- Diff:
solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java ---
@@ -962,6 +982,76 @@ public static CollectionOperation get(CollectionAction
action) {
}
}
+ private static SolrParams convertToV1WhenRequired(SolrQueryRequest req,
ModifiableSolrParams params) {
+ SolrParams v1Params = params; // (maybe...)
+
+ // in the v2 world we get a data map based on the json request, from
the CommandOperation associated
+ // with the request, so locate that if we can.. if we find it we have
to translate the v2 request
+ // properties to v1 params, otherwise we're already good to go.
+ List<CommandOperation> cmds = req.getCommands(true);
+ if (cmds.size() > 1) {
+ // todo: not sure if this is the right thing to do here, but also
not sure what to do if there is more than one...
+ throw new SolrException(BAD_REQUEST, "Only one command is allowed
when creating a routed alias");
+ }
+ CommandOperation c = cmds.size() == 0 ? null : cmds.get(0);
+ if (c != null) { // v2 api, do conversion to v1
+ v1Params = new
BaseHandlerApiSupport.V2ToV1SolrParams(CollectionApiMapping.Meta.CREATE_COLLECTION,
+ req.getPathTemplateValues(), true, params,
+ new CommandOperation("create",
c.getDataMap().get("create-collection")));
+ }
+ return v1Params;
+ }
+
+ private static Map<String, Object>
parseColletionCreationProps(CollectionsHandler h, SolrParams params, String
prefix)
--- End diff --
fixed in update
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
