[
https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327038#comment-16327038
]
Mano Kovacs commented on SOLR-10912:
------------------------------------
Hey Steve, that would be great as I couldn't work on this lately and probably
will be busy in the next weeks.
The current change is here:
[https://github.com/apache/lucene-solr/compare/master...manokovacs:feature/SOLR-10912]
Also, I have the list with the remaining work I was planning to do and the open
questions.
{quote}Steps remaining:
* Multiple module test currently duplicates the failed test result, fixing
shortly.
* Add test to call {{-validate-source-patterns}}
* Finalize the runner script to setup Yetus, similarly to Hadoop.
* Verify the test-patch with Github PR
* Add Patch Available status for SOLR project (and update the script to look
for that). [~steve_rowe], regarding to our IRL conversation, could you help me
with adding that status in JIRA?
* Add {{Precommit-SOLR}} and {{Precommit-LUCENE}} jenkins jobs
Open questions:
1. As you can see, a patch with two log entries had 6 (flaky) test failures.
Assuming flaky tests will not go away very soon, would it still be useful to
have this test-patch?
2. I propose starting with the smallest set of tests (ie. affected modules) and
extend them later to dependent modules.
{quote}
Let me know if I can be of any help.
> Adding automatic patch validation
> ---------------------------------
>
> Key: SOLR-10912
> URL: https://issues.apache.org/jira/browse/SOLR-10912
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Mano Kovacs
> Priority: Major
> Attachments: SOLR-10912.ok-patch-in-core.patch,
> SOLR-10912.sample-patch.patch, SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or
> other Apache projects are using (see link). This would ensure that every
> patch passes a certain set of criterions before getting approved. It would
> save time for developer (faster feedback loop), save time for committers
> (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be
> a good direction to start. This jira could be the board of discussing the
> preferred solution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
