[ https://issues.apache.org/jira/browse/LUCENE-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053885#comment-13053885 ]
Simon Willnauer commented on LUCENE-3225: ----------------------------------------- {quote} BTW, similarly, I think we have a missing API in DISI (for scoring): advance always does a next() if the target doc doesn't match. But we can get substantial performance gains in some cases (see LUCENE-1536) if we had an advanceExact that would not do the next and simply tell us if this doc matched or not. {quote} +1!! {quote} But I agree another boolean to seek isn't great; maybe instead we can make a seperate seekExact method? Default impl would just call seek (and get no perf gains). {quote} thats another option and I like that better though. Yet the other should the be seekFloor no? bq. not sure what you meant here? nevermind I only looked at the top of the patch and figured that we only safe the loading into bytesref but there is more about it... > Optimize TermsEnum.seek when caller doesn't need next term > ---------------------------------------------------------- > > Key: LUCENE-3225 > URL: https://issues.apache.org/jira/browse/LUCENE-3225 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 4.0 > > Attachments: LUCENE-3225.patch > > > Some codecs are able to save CPU if the caller is only interested in > exact matches. EG, Memory codec and SimpleText can do more efficient > FSTEnum lookup if they know the caller doesn't need to know the term > following the seek term. > We have cases like this in Lucene, eg when IW deletes documents by > Term, if the term is not found in a given segment then it doesn't need > to know the ceiling term. Likewise when TermQuery looks up the term > in each segment. > I had done this change as part of LUCENE-3030, which is a new terms > index that's able to save seeking for exact-only lookups, but now that > we have Memory codec that can also save CPU I think we should commit > this today. > The change adds a "boolean onlyExact" param to seek(BytesRef). -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org