[
https://issues.apache.org/jira/browse/SOLR-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336933#comment-16336933
]
Robert Muir commented on SOLR-11892:
------------------------------------
-1: the exact exception type is important. Sorry, I don't think we should make
our directory implementations lenient.
Nor should we use such static pre-canned exceptions here. Not the place to try
to be cute: There is already a filesystem metadata operation happening:
https://gist.github.com/jboner/2841832
And this really needs to be a lucene issue, not a solr one.
> Avoid unnecessary exceptions in FSDirectory and RAMDirectory
> ------------------------------------------------------------
>
> Key: SOLR-11892
> URL: https://issues.apache.org/jira/browse/SOLR-11892
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
>
> In privateDeleteFile, just use deleteIfExists.
> in RamDirectory we can declare a static exception and create it once.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
