[
https://issues.apache.org/jira/browse/LUCENE-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349049#comment-16349049
]
Erick Erickson commented on LUCENE-8148:
----------------------------------------
I have no strong preference whether it's the test or non-test code first.
Figured working on test code first would let me get my feet wet without risking
too much, but it's all the same in the end.
I got all the precommit lint warnings out of Solr's test code last night except
a couple so at least that part may not be as daunting as I fear. Just a lot of
secretarial work for the most part.
Yeah, compiler warnings. Deprecations are next on my list since there are so
_many_ of them. From there on to other warnings.... I'm trying to break things
into smaller chunks to keep from getting too intimidated by how many of them
there are.
> Get precommit Lint warnings out of test code
> --------------------------------------------
>
> Key: LUCENE-8148
> URL: https://issues.apache.org/jira/browse/LUCENE-8148
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
>
> Mostly putting this up for discussion. I'm starting to work on Solr test lint
> warnings, it seems right to break the Lucene changes and Solr changes into
> separate JIRAs.
> First of all, do people have objections to me mucking around in the Lucene
> test code to do this? The eventual goal here is to get to the point where we
> can turn on precommit failures on lint warnings. Deprecations maybe as well,
> but that's a separate issue, as is non-test code.
> I expect to see a lot of pretty safe issues, then a series I'm not sure of,
> I'll ask when I find them if I wind up carrying this forward.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
