[ 
https://issues.apache.org/jira/browse/LUCENE-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352456#comment-16352456
 ] 

Ignacio Vera commented on LUCENE-8157:
--------------------------------------

GeoPolygonFactory, line 1521:

 

{color:#cc7832}final boolean {color}isNewPointWithin = 
currentEdge.{color:#9876aa}plane{color}.isWithin(newPoint){color:#cc7832};
{color}{color:#cc7832}final {color}GeoPoint pointToPresent = 
currentEdge.{color:#9876aa}startPoint{color}{color:#cc7832};
{color}{color:#cc7832}
{color}{color:#cc7832}final {color}SidedPlane newPlane = {color:#cc7832}new 
{color}SidedPlane(pointToPresent{color:#cc7832}, 
{color}isNewPointWithin{color:#cc7832}, 
{color}pointList.get(startIndex){color:#cc7832}, 
{color}newPoint){color:#cc7832};{color}

 

 

> GeoPolygon factory fails in recognize convex polygon
> ----------------------------------------------------
>
>                 Key: LUCENE-8157
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8157
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial3d
>            Reporter: Ignacio Vera
>            Priority: Major
>         Attachments: LUCENE-8157-plane.patch, LUCENE-8157-test.patch, 
> LUCENE-8157.patch
>
>
> When a polygon contains three consecutive points which are nearly co-planar, 
> the polygon factory may fail to recognize the concavity/convexity of the 
> polygon. I think the problem is the way the sideness for a polygon edge is 
> calculated. It relies in the position of the next point in respect of the 
> previous polygon edge which fails on the case explained above because of 
> numerical imprecision. The result is that sideness is messed up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to