[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352893#comment-16352893
]
Uwe Schindler edited comment on LUCENE-8156 at 2/5/18 8:34 PM:
---------------------------------------------------------------
Hi Adrien,
I have the feeling we can't fix this. There are already bugs open and the
problem with "ant -f fetch.xml" is bringing many problems. It adds horrible
(more than 10 year old versions of several tools into ant's default classpath).
My question: Why does one install those outdated stuff? If it's a bug in the
installation - and we should the user tell how to fix it. We had a similar
request where somebody else's build was broken, because some crazy Linux
Package manager called "ant -f fetch.xml" during installation. We closed that
as won't fix (have to look it up).
My idea would be to fail early: If ANT finds asm's ClassReader or some other
bad class files on default class path when starting up, it bails out, telling
user to fix his classpath.
Why does ES's half-hourly Lucene tests use this? I'd cleanup the ant/lib folder!
was (Author: thetaphi):
Hi Adrien,
I have the feeling we can't fix this. There are already bugs open and the
problem with "ant -f fetch.xml" is bringing many problems. It adds horrible
(more than 10 year old versions of several tools into ant's default classpath).
My question: Why does one install those outdated stuff? If it's a bug in the
installation we should the user tell how to fix it. We had a similar request
where somebody else's build was broken, because some crazy Linux Package
manager called "ant -f fetch.xml" during installation. We closed that as won't
fix (have to look it up).
My idea would be to fail early: If ANT finds asm's ClassReader or some other
bad class files on default class path when starting up, it bails out, telling
user to fix his classpath.
Why does ES's half-hourly Lucene tests use this? I'd cleanup the ant/lib folder!
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --------------------------------------------------------------------------
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Priority: Major
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
