[
https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355620#comment-16355620
]
David Smiley commented on LUCENE-8126:
--------------------------------------
Overall looks good [~ivera]. I think it's ready to be committed,
notwithstanding some "ant precommit" stuff regarding the new dependency I'm
sure you'll bump into.
The main question in my mind is how we communicate when someone should use this
SPT. For the other 3 I know when they are most appropriate. But for this; I
just don't know. In the description you state:
{quote}Using this pixelization scheme reduces the size of the index, improves
the performance of the queries and reduces the loading time for non-point
shapes.
{quote}
Could you please share some numbers?
BTW GitHub-Jira integration now puts code review comments into the "Worklog"
tab in Jira which doesn't flood the comments with noisy stuff or send redundant
email notifications. If someone interested wants to follow the activity and be
notified, I believe they need to "subscribe" to the PR in GitHub.
> Spatial prefix tree based on S2 geometry
> ----------------------------------------
>
> Key: LUCENE-8126
> URL: https://issues.apache.org/jira/browse/LUCENE-8126
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/spatial-extras
> Reporter: Ignacio Vera
> Assignee: Ignacio Vera
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Hi [~dsmiley],
> I have been working on a prefix tree based on goggle S2 geometry
> (https://s2geometry.io/) to be used mainly with Geo3d shapes with very
> promising results, in particular for complex shapes (e.g polygons). Using
> this pixelization scheme reduces the size of the index, improves the
> performance of the queries and reduces the loading time for non-point shapes.
> If you are ok with this contribution and before providing any code I would
> like to understand what is the correct/prefered approach:
> 1) Add new depency to the S2 library
> (https://mvnrepository.com/artifact/io.sgr/s2-geometry-library-java). It has
> Apache 2.0 license so it should be ok.
> 2) Create a utility class with all methods necessary to navigate the S2 tree
> and create shapes from S2 cells (basically port what we need from the library
> into Lucene).
> What do you think?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
