[ 
https://issues.apache.org/jira/browse/LUCENE-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358207#comment-16358207
 ] 

Alan Woodward commented on LUCENE-3475:
---------------------------------------

{quote}but won't generate a graph unless the input is a graph too
{quote}
Correct
{quote}Should we just replace it?
{quote}
I'll need to rejig it slightly so that it produces identical output, but I 
think that's worth doing.  And a drop-in replacement would be easier for 
upgrades as well.

I'll add some more tests, mixing up CannedTokenStream and real analyzer outputs.

> ShingleFilter should handle positionIncrement of zero, e.g. synonyms
> --------------------------------------------------------------------
>
>                 Key: LUCENE-3475
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3475
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: modules/analysis
>            Reporter: Cameron
>            Assignee: Alan Woodward
>            Priority: Minor
>              Labels: newdev
>         Attachments: LUCENE-3475.patch
>
>
> ShingleFilter is creating shingles for a single term that has been expanded 
> by synonyms when it shouldn't. The position increment is 0.
> As an example, I have an Analyzer with a SynonymFilter followed by a 
> ShingleFilter. Assuming car and auto are synonyms, the SynonymFilter produces 
> two tokens and position 1: car, auto. The ShingleFilter is then producing 3 
> tokens, when there should only be two: car, car auto, auto. This behavior 
> seems incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to