Github user jpountz commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/320#discussion_r167482889
  
    --- Diff: lucene/core/src/test/org/apache/lucene/index/TestFieldInfos.java 
---
    @@ -0,0 +1,86 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.lucene.index;
    +
    +
    +import java.util.Iterator;
    +
    +import org.apache.lucene.analysis.MockAnalyzer;
    +import org.apache.lucene.document.Document;
    +import org.apache.lucene.document.Field;
    +import org.apache.lucene.document.StringField;
    +import org.apache.lucene.store.Directory;
    +import org.apache.lucene.util.LuceneTestCase;
    +
    +public class TestFieldInfos extends LuceneTestCase {
    +
    +  public void testFieldInfos() throws Exception{
    +    Directory dir = newDirectory();
    +    IndexWriter writer = new IndexWriter(dir, newIndexWriterConfig(new 
MockAnalyzer(random()))
    +        .setMergePolicy(NoMergePolicy.INSTANCE));
    +
    +    Document d1 = new Document();
    +    for (int i = 0; i < 15; i++) {
    +      d1.add(new StringField("f" + i, "v" + i, Field.Store.YES));
    +    }
    +    writer.addDocument(d1);
    +    writer.commit();
    +
    +    Document d2 = new Document();
    +    d2.add(new StringField("f0", "v0", Field.Store.YES));
    +    d2.add(new StringField("f15", "v15", Field.Store.YES));
    +    d2.add(new StringField("f16", "v16", Field.Store.YES));
    +    writer.addDocument(d2);
    +    writer.commit();
    +
    +    Document d3 = new Document();
    +    writer.addDocument(d3);
    +    writer.close();
    +
    +    SegmentInfos sis = SegmentInfos.readLatestCommit(dir);
    +    assertEquals(3, sis.size());
    +
    +    FieldInfos fis1 = IndexWriter.readFieldInfos(sis.info(0));
    +    FieldInfos fis2 = IndexWriter.readFieldInfos(sis.info(1));
    +    FieldInfos fis3 = IndexWriter.readFieldInfos(sis.info(2));
    +
    +
    +    // testing dense FieldInfos
    +    Iterator<FieldInfo>  it = fis1.iterator();
    +    int i = 0;
    +    while(it.hasNext()) {
    +      FieldInfo fi = it.next();
    +      assertEquals(i, fi.number);
    +      assertEquals("f" + i , fi.name);
    +      i++;
    +    }
    +
    +    // testing sparse FieldInfos
    +    assertEquals("f0", fis2.fieldInfo(0).name);
    +    assertNull(fis2.fieldInfo(1));
    +    assertEquals("f15", fis2.fieldInfo(15).name);
    +    assertEquals("f16", fis2.fieldInfo(16).name);
    +
    +    // testing empty FieldInfos
    +    assertNull(fis3.fieldInfo(0));
    +    assertEquals(0, fis3.size());
    +    Iterator<FieldInfo> it3 = fis3.iterator();
    +    assertFalse(it3.hasNext());
    +    dir.close();
    --- End diff --
    
    in each of these 3 cases, can you also do some lookups by name and by 
number?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to