[ 
https://issues.apache.org/jira/browse/SOLR-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361178#comment-16361178
 ] 

Erick Erickson commented on SOLR-10809:
---------------------------------------

Preliminary patch attached. Anyone with the spare time to glance over some bits 
is welcome. A couple of notes:

Look for my initials (EOE). I'd put //nocommit in, but that aborts precommit 
before generating warnings...

The bits marked with EOE are things I want to look at more closely. All the 
times I added SuppressWarnings are places that seem to cause test failures, I 
dug into the code a bit and think I see why, but again any other eyes on the 
code are welcome.

Specifying the Closeable interface then wrapping something else that closeable 
causes some confusion, especially when the wrap is temporary.

By and large I've resisted the temptation to rearrange code. One exception is 
DocSet where I removed the Closeable interface was there for future off-heap 
implementations, and that's not happening IIUC. [~yo...@apache.org] any 
objections?

I have to look this over and run the full test suite 5 or 10 times more and see 
what shakes out. But at this point there are no precommit warnings at all in 
solr/core and all tests pass (at least there are no new failures, we'll talk 
some other time about how many routine failures there are and whether we're 
ever going to stop accepting failing tests as the norm).

> Get precommit lint warnings out of Solr core
> --------------------------------------------
>
>                 Key: SOLR-10809
>                 URL: https://issues.apache.org/jira/browse/SOLR-10809
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-10809.patch
>
>
> Changing to fit "the new paradigm" of de-linting a directory at a time. I 
> hope to get precommit to fail on precommit warnings from some point on down 
> the tree, and solr/core is the first unit I've been working on.
> I'll have a patch soon.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to