[ https://issues.apache.org/jira/browse/SOLR-11749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367468#comment-16367468 ]
Jason Gerlowski edited comment on SOLR-11749 at 2/16/18 3:26 PM: ----------------------------------------------------------------- I attached a patch above which adds enough tests to establish a pattern for how these might be developed. I tried my best to make the tests look as much as possible like the Java JUnit tests everyone is familiar with. - there are test suites (files named "test_*.sh" anywhere under {{bin-test}}) - inside suites, there are individual test cases (bash functions prefixed with {{solr_test_}}) - there are @Before and @After analogues ({{solr_unit_test_before}} and {{solr_unit_test_after}}) - there are @BeforeClass and @AfterClass analog [^test-output.txt] ues ({{solr_suite_before}} and {{solr_suite_after}}) The output, with the uploaded patch, is also attached. I'm curious what people think of the attached approach. If people like it (or at least no one hates it too much), I'm happy to go forward and commit the base framework and start adding a base level of test coverage. And porting the approach to Windows batch scripts, so we can test bin/solr.cmd as well. was (Author: gerlowskija): I attached a patch above which adds enough tests to establish a pattern for how these might be developed. I tried my best to make the tests look as much as possible like the Java JUnit tests everyone is familiar with. - there are test suites (files named "test_*.sh" anywhere under {{bin-test}}) - inside suites, there are individual test cases (bash functions prefixed with {{solr_test_}}) - there are @Before and @After analogues ({{solr_unit_test_before}} and {{solr_unit_test_after}}) - there are @BeforeClass and @AfterClass analog [^test-output.txt] ues ({{solr_suite_before}} and {{solr_suite_after}}) The output, with the uploaded patch, is also attached. > regression-test-like functionality for bin/solr* > ------------------------------------------------ > > Key: SOLR-11749 > URL: https://issues.apache.org/jira/browse/SOLR-11749 > Project: Solr > Issue Type: Wish > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools > Reporter: Christine Poerschke > Priority: Minor > Attachments: SOLR-11749.patch, SOLR-11749.patch, test-output.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org