[ 
https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369645#comment-16369645
 ] 

Koji Sekiguchi commented on SOLR-11795:
---------------------------------------

Thank you for updating the patch. I can see hard coded luceneMatchVersion in 
the patch:

{code}
<luceneMatchVersion>7.1.0</luceneMatchVersion>
{code}

You can rephrase it like this:

{code}
<luceneMatchVersion>${tests.luceneMatchVersion:LATEST}</luceneMatchVersion>
{code}

And I think your solrconfig.xml for test is still fat... Please consult 
solr/contrib/langid for making test config more compact.

> Add Solr metrics exporter for Prometheus
> ----------------------------------------
>
>                 Key: SOLR-11795
>                 URL: https://issues.apache.org/jira/browse/SOLR-11795
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: 7.2
>            Reporter: Minoru Osuka
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>         Attachments: SOLR-11795-2.patch, SOLR-11795-3.patch, 
> SOLR-11795-4.patch, SOLR-11795-5.patch, SOLR-11795-6.patch, SOLR-11795.patch, 
> solr-dashboard.png, solr-exporter-diagram.png
>
>
> I 'd like to monitor Solr using Prometheus and Grafana.
> I've already created Solr metrics exporter for Prometheus. I'd like to 
> contribute to contrib directory if you don't mind.
> !solr-exporter-diagram.png|thumbnail!
> !solr-dashboard.png|thumbnail!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to