[ https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373489#comment-16373489 ]
Michael Gibney commented on SOLR-7798: -------------------------------------- I was indeed developing on master. Which test case is failing for you? I'm getting a couple of failed tests on master (364b680afaf9) that seem to be unrelated to the ExpandComponent changes: {code} [junit4] Tests with failures [seed: 2723B1A9FC179033]: [junit4] - org.apache.solr.handler.component.DummyCustomParamSpellChecker.initializationError [junit4] - org.apache.solr.handler.component.ResourceSharingTestComponent.initializationError {code} but when I try to selectively run the ExpandComponent test I'm getting: {code} ant -Dtests.class="org.apache.solr.handler.component.TestExpandComponent" test ... [junit4] Tests summary: 0 suites, 0 tests {code} No errors ... but I guess something is still amiss. > Improve robustness of ExpandComponent > ------------------------------------- > > Key: SOLR-7798 > URL: https://issues.apache.org/jira/browse/SOLR-7798 > Project: Solr > Issue Type: Improvement > Components: SearchComponents - other > Reporter: Jörg Rathlev > Assignee: Joel Bernstein > Priority: Minor > Attachments: expand-component.patch, expand-npe.patch > > Time Spent: 10m > Remaining Estimate: 0h > > The {{ExpandComponent}} causes a {{NullPointerException}} if accidentally > used without prior collapsing of results. > If there are multiple documents in the result which have the same term value > in the expand field, the size of the {{ordBytes}}/{{groupSet}} differs from > the {{count}} value, and the {{getGroupQuery}} method creates an incompletely > filled {{bytesRef}} array, which later causes a {{NullPointerException}} when > trying to sort the terms. > The attached patch extends the test to demonstrate the error, and modifies > the {{getGroupQuery}} methods to create the array based on the size of the > input maps. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org