Uwe Schindler commented on SOLR-11795:

Just a complaint: Why are tests written like this:

String configFile = getFile("conf/config.yml").getAbsolutePath();
SolrCollectorConfig collectorConfig = new Yaml().loadAs(new BufferedReader(new 
InputStreamReader(new FileInputStream(configFile),"UTF-8")), 

# Why does it not use {{StandardCharsets.UTF_8}}??
# Why does it use a {{java.io.File}} and stuff like 
{{java.io.FileInputStream}}. Thos classes are forbidden in Lucene and we should 
get rid of them in Solr, too. Most new code uses {{java.nio.file.*}}, but for 
this test it's not even needed to use a File path, just open it as resource and 
open the InputStream using TestUtils!
# This leaks files, which causes tests to possibly fail on Windows, as files 
are not closed. Please add try-with-resources.

> Add Solr metrics exporter for Prometheus
> ----------------------------------------
>                 Key: SOLR-11795
>                 URL: https://issues.apache.org/jira/browse/SOLR-11795
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: 7.2
>            Reporter: Minoru Osuka
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>             Fix For: master (8.0), 7.3
>         Attachments: SOLR-11795-2.patch, SOLR-11795-3.patch, 
> SOLR-11795-4.patch, SOLR-11795-5.patch, SOLR-11795-6.patch, 
> SOLR-11795-7.patch, SOLR-11795-8.patch, SOLR-11795-9.patch, 
> SOLR-11795-dev-tools.patch, SOLR-11795.patch, solr-dashboard.png, 
> solr-exporter-diagram.png
>          Time Spent: 20m
>  Remaining Estimate: 0h
> I 'd like to monitor Solr using Prometheus and Grafana.
> I've already created Solr metrics exporter for Prometheus. I'd like to 
> contribute to contrib directory if you don't mind.
> !solr-exporter-diagram.png|thumbnail!
> !solr-dashboard.png|thumbnail!

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to