[ https://issues.apache.org/jira/browse/LUCENE-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir reopened LUCENE-3191: --------------------------------- Reopening: this code in SlowCollatedStringComparator is totally broken: {noformat} @Override public int compareValues(BytesRef first, BytesRef second) { if (first == null) { if (second == null) { return 0; } return -1; } else if (second == null) { return 1; } else { return collator.compare(first, second); } } {noformat} I haven't tracked this issue to understand whats going on here, but you cannot pass BytesRefs to collator.compare. If this code is ever reached (and looking at the test i wrote for this damn thing, its unclear if this code is even necessary?!), it *will* throw ClassCastException: http://download.oracle.com/javase/1,5.0/docs/api/java/text/Collator.html#compare(java.lang.Object, java.lang.Object) > Add TopDocs.merge to merge multiple TopDocs > ------------------------------------------- > > Key: LUCENE-3191 > URL: https://issues.apache.org/jira/browse/LUCENE-3191 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 3.3, 4.0 > > Attachments: LUCENE-3191-3x.patch, LUCENE-3191.patch, > LUCENE-3191.patch, LUCENE-3191.patch, LUCENE-3191.patch, LUCENE-3191.patch > > > It's not easy today to merge TopDocs, eg produced by multiple shards, > supporting arbitrary Sort. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org