[ 
https://issues.apache.org/jira/browse/LUCENE-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381343#comment-16381343
 ] 

ASF subversion and git services commented on LUCENE-8188:
---------------------------------------------------------

Commit 6e79bc7d5c6b0fafe27ea732ece403dd3807d673 in lucene-solr's branch 
refs/heads/branch_7x from Chris Hostetter
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6e79bc7 ]

LUCENE-8188: Fixed bugs in OpenNLPOpsFactory that were causing InputStreams 
fetched from the ResourceLoader to be leaked

(cherry picked from commit 1bf718948696e69053bd5b7177b9ed32b5f57015)

Conflicts:
        lucene/CHANGES.txt


> OpenNLPOpsFactory leaks filehandles of models
> ---------------------------------------------
>
>                 Key: LUCENE-8188
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8188
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Priority: Major
>         Attachments: LUCENE-8188.patch
>
>
> I appears that all methods in {{OpenNLPOpsFactory}} which use a 
> {{ResourceLoader}} to get an InputStream to use for building a model are not 
> closing those {{InputStreams}}
> This doesn't seem to negatively affect any existing 
> {{lucene/analysis/opennlp}} tests, because the JVM doesn't know/care that 
> there is a filehandle still open at the end of the test (is there a way to 
> make the test complain?)  but it does seem to cause a Solr level test failure 
> on windows (SOLR-12046) because the solr tests create a temp dir where 
> pre-built models are copied for use, and when the test completes the cleanup 
> attempts to delete those copies of the files but windows won't let it because 
> they are still open.
> presumably if a {{lucene/analysis/opennlp}} test also made a copy of the 
> files a similar failure would be triggered -- but only on windows



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to