[ 
https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386879#comment-16386879
 ] 

Cassandra Targett commented on SOLR-11795:
------------------------------------------

A couple of really tiny things I noticed when I was reviewing the 
documentation. These could go in another issue if you'd like since this one is 
resolved already:

* I downloaded the branch_7x build from Jenkins in order to try it out, and 
noticed that in {{contrib/prometheus-exporter}} there is a {{README.txt}} but 
it only contains the text literally "README.md". In the source, I see 
{{README.md}} also but it and its contents are not coming out in the built 
version.
* The alternative form of the {{-n}} parameter is {{--num-thread}}, but 
everywhere else in the code and docs the word "threads" is used in its plural 
form. I think it will cause a bit of confusion is the parameter is 
{{--num-thread}} instead of {{--num-threads}}, and we should change it before 
it's released.
** Speaking of which, anything else the docs could say about this parameter 
besides "the number of threads"? What's a recommended number of threads? Is 
there a default number? What are the impacts of higher and lower numbers of 
threads?

> Add Solr metrics exporter for Prometheus
> ----------------------------------------
>
>                 Key: SOLR-11795
>                 URL: https://issues.apache.org/jira/browse/SOLR-11795
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: 7.2
>            Reporter: Minoru Osuka
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>             Fix For: master (8.0), 7.3
>
>         Attachments: SOLR-11795-10.patch, SOLR-11795-11.patch, 
> SOLR-11795-2.patch, SOLR-11795-3.patch, SOLR-11795-4.patch, 
> SOLR-11795-5.patch, SOLR-11795-6.patch, SOLR-11795-7.patch, 
> SOLR-11795-8.patch, SOLR-11795-9.patch, SOLR-11795-dev-tools.patch, 
> SOLR-11795.patch, solr-dashboard.png, solr-exporter-diagram.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I 'd like to monitor Solr using Prometheus and Grafana.
> I've already created Solr metrics exporter for Prometheus. I'd like to 
> contribute to contrib directory if you don't mind.
> !solr-exporter-diagram.png|thumbnail!
> !solr-dashboard.png|thumbnail!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to