Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/323#discussion_r173525391
--- Diff:
solr/core/src/java/org/apache/solr/schema/LatLonPointSpatialField.java ---
@@ -75,8 +77,16 @@ protected SpatialStrategy newSpatialStrategy(String
fieldName) {
return new LatLonPointSpatialStrategy(ctx, fieldName,
schemaField.indexed(), schemaField.hasDocValues());
}
- public String geoValueToStringValue(long value) {
- return new String(decodeLatitudeCeil(value) + "," +
decodeLongitudeCeil(value));
+ /**
+ * Converts to "lat, lon"
+ * @param value Non-null; stored location field data
+ * @return Non-null; "lat, lon" with 6 decimal point precision
--- End diff --
Why 6 decimal points? Is that sufficient to represent the data to as much
precision as is decoded? Perhaps instead of putting the constant '6' in the
code, it should be calculated so that we can see how 6 is arrived at. What
does that translate to in the metric system?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
