[
https://issues.apache.org/jira/browse/LUCENE-5143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395238#comment-16395238
]
Jan Høydahl commented on LUCENE-5143:
-------------------------------------
Updated LUCENE-5143.patch with these changes:
* Added option {{--local-keys <path-to-KEYS-file>}} as alternative to pulling
online version
* Moved key check code to separate function
To sum up the full proposal:
We will STOP publishing version specific KEYS files, instead there will be one
top level [https://archive.apache.org/dist/lucene/KEYS] for both lucene and
solr, which will be kept up to date with all historic RM key IDs. The addition
of the KEYS file check in this patch, the buildAndPushRelease script will abort
if RM's gpg key is not present in that KEYS file. Steps to roll out:
# Apply this patch to buildAndPushRelease.py
# Release version 7.4 (this is the first release without the version-specific
KEYS file)
# Apply the READMEs patch against dist svn
# Delete {{lucene/KEYS}} and {{solr/KEYS}} since they are not in use
# Consider documenting usage of KEYS file on Lucene and Solr's respective
Download web pages
PS: The pylucene project may continue using their local KEYS file.
> rm or formalize dealing with "general" KEYS files in our dist dir
> -----------------------------------------------------------------
>
> Key: LUCENE-5143
> URL: https://issues.apache.org/jira/browse/LUCENE-5143
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Hoss Man
> Priority: Major
> Attachments: LUCENE-5143.patch, LUCENE-5143.patch, LUCENE-5143.patch,
> LUCENE-5143_READMEs.patch, LUCENE-5143_READMEs.patch
>
>
> At some point in the past, we started creating a snapshots of KEYS (taken
> from the auto-generated data from id.apache.org) in the release dir of each
> release...
> http://www.apache.org/dist/lucene/solr/4.4.0/KEYS
> http://www.apache.org/dist/lucene/java/4.4.0/KEYS
> http://archive.apache.org/dist/lucene/java/4.3.0/KEYS
> http://archive.apache.org/dist/lucene/solr/4.3.0/KEYS
> etc...
> But we also still have some "general" KEYS files...
> https://www.apache.org/dist/lucene/KEYS
> https://www.apache.org/dist/lucene/java/KEYS
> https://www.apache.org/dist/lucene/solr/KEYS
> ...which (as i discovered when i went to add my key to them today) are stale
> and don't seem to be getting updated.
> I vaguely remember someone (rmuir?) explaining to me at one point the reason
> we started creating a fresh copy of KEYS in each release dir, but i no longer
> remember what they said, and i can't find any mention of a reason in any of
> the release docs, or in any sort of comment in buildAndPushRelease.py
> we probably do one of the following:
> * remove these "general" KEYS files
> * add a disclaimer to the top of these files that they are legacy files for
> verifying old releases and are no longer used for new releases
> * ensure these files are up to date stop generating per-release KEYS file
> copies
> * update our release process to ensure that the general files get updated on
> each release as well
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
