Lets fix or move to @AwaitsFix for cases like these. I believe Erick just wanted to verify that these @AwaitFix were still broken when he moved them to @BadApple, but the idea was to put them back in @AwaitsFix if they prove to be effectively broken.
I’m also +1 to reopen the test-specific Jira issue in such cases as other people suggested in SOLR-12028. Tomás > On Mar 15, 2018, at 2:13 AM, Andrzej Białecki <[email protected]> wrote: > > Hi, > > This test is marked BadApple but fails 100% all the time in my local builds > and on jenkins. This is not what a bad apple means … it’s simply broken and > needs to be fixed. > > The issue that changed AwaitsFix to BadApple is SOLR-11134 (Apache Jira seems > to have some problems at the moment - I can’t reopen the issue). > > I propose to do one of the following: > > * fix it :) > > * change the annotation back to AwaitsFix (assuming that at some point some > gentle soul will write a script to run & report AwaitsFix tests so that they > are not simply ignored) > > * leave it as is (and pretend it’s ok …) > > — > > Andrzej Białecki >
