[ https://issues.apache.org/jira/browse/LUCENE-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057565#comment-13057565 ]
Chris Male commented on LUCENE-3256: ------------------------------------ Command for patch is: {code} svn move lucene/src/java/org/apache/lucene/search/function/CustomScoreQuery.java modules/queries/src/java/org/apache/lucene/queries/ svn move lucene/src/java/org/apache/lucene/search/function/CustomScoreProvider.java modules/queries/src/java/org/apache/lucene/queries/ svn move solr/src/java/org/apache/solr/search/function/BoostedQuery.java modules/queries/src/java/org/apache/lucene/queries/function/ svn --parents mkdir modules/queries/src/test/org/apache/lucene/queries/function svn move lucene/src/test/org/apache/lucene/search/function/TestCustomScoreQuery.java modules/queries/src/test/org/apache/lucene/queries/ {code} > Consolidate CustomScoreQuery, ValueSourceQuery and BoostedQuery > ---------------------------------------------------------------- > > Key: LUCENE-3256 > URL: https://issues.apache.org/jira/browse/LUCENE-3256 > Project: Lucene - Java > Issue Type: Sub-task > Components: core/search > Reporter: Chris Male > Fix For: 4.0 > > Attachments: LUCENE-3256.patch, LUCENE-3256.patch, LUCENE-3256.patch > > > Lucene's CustomScoreQuery and Solr's BoostedQuery do essentially the same > thing: they boost the scores of Documents by the value from a ValueSource. > BoostedQuery does this in a direct fashion, by accepting a ValueSource. > CustomScoreQuery on the other hand, accepts a series of ValueSourceQuerys. > ValueSourceQuery seems to do exactly the same thing as FunctionQuery. > With Lucene's ValueSource being deprecated / removed, we need to resolve > these dependencies and simplify the code. > Therefore I recommend we do the following things: > - Move CustomScoreQuery (and CustomScoreProvider) to the new Queries module > and change it over to use FunctionQuerys instead of ValueSourceQuerys. > - Deprecate Solr's BoostedQuery in favour of the new CustomScoreQuery. CSQ > provides a lot of support for customizing the scoring process. > - Move and consolidate all tests of CSQ and BoostedQuery, to the Queries > module and have them test CSQ instead. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org