[
https://issues.apache.org/jira/browse/LUCENE-8208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400652#comment-16400652
]
Karl Wright commented on LUCENE-8208:
-------------------------------------
[~ivera] The method is comparing two vectors, in space, to see if they are
parallel. But I agree that it is not in agreement with its name.
I would suggest we keep this functionality as is but change the name of the
method to "isParallel()". Then we can also introduce
"isNumericallyIdentical()" to basically just compare x, y, and z values. We
will need to change most usages in the code to isParallel().
> Vector.isNumericallyIdentical() can produce unexpected results
> --------------------------------------------------------------
>
> Key: LUCENE-8208
> URL: https://issues.apache.org/jira/browse/LUCENE-8208
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Priority: Major
> Attachments: LUCENE-8208.patch
>
>
> The method {{Vector.isNumericallyIdentical()}} seems to produce wrong results
> in some cases. For example it considers that vectors (1,0,0) and (-1,0,0) are
> numerically identical whichI is probably wrong.
> This behavior might produce unexpected behaviors down the line.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
