[
https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403172#comment-16403172
]
Steve Rowe edited comment on SOLR-10912 at 3/17/18 12:54 AM:
-------------------------------------------------------------
{quote}
bq. 6. Request ASF Infrastructure to add LUCENE and SOLR to the list of
projects that use the PreCommit-Admin Jenkins job to enqueue precommit runs for
new patches on LUCENE/SOLR JIRAs with the "Patch Available" state. (I'll make a
JIRA for this and link it to this issue.)
Done: INFRA-16194
{quote}
This is now completed.
The {{PreCommit-Admin}} job is scheduled to run every 10 minutes (can stretch
to 40 minutes or longer though, depending on executor availability), and in the
first runs after INFRA-16194 was done, two Lucene/Solr qualifying issues (i.e.
with "Patch Available" status and updated some time in the last 2 weeks) were
submitted: LUCENE-8197 and SOLR-11331. Unfortunately, I had not properly
configured the auth token on the {{PreCommit-\{LUCENE,SOLR\}-Build}} jobs --
{{PreCommit-Admin}} always supplies token 'hadoopqa' when it triggers all
{{PreCommit-\*}} jobs, and I had configured the jobs to expect 'lucenesolrqa';
I've since fixed this -- and as a result the builds didn't kick off, but
{{PreCommit-Admin}}'s database of submitted patches now includes the
attachments that were submitted as already dealt with, so those patches won't
be validated until somebody uploads new patches there.
I re-opened and switched status to "Patch Available" on the two test issues I
created to manually test the new {{PreCommit}} jobs (LUCENE-8210 and
SOLR-12106). {{PreCommit-Admin}} has now run again and has queued the
corresponding {{PreCommit}} jobs to validate the patches on those two issues
(once they run the results will be available at
[https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-LUCENE-Build/10/]
and
[https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-SOLR-Build/6/]).
was (Author: steve_rowe):
{quote}
bq. 6. Request ASF Infrastructure to add LUCENE and SOLR to the list of
projects that use the PreCommit-Admin Jenkins job to enqueue precommit runs for
new patches on LUCENE/SOLR JIRAs with the "Patch Available" state. (I'll make a
JIRA for this and link it to this issue.)
Done: INFRA-16194
{quote}
This is now completed.
The PreCommit-Admin is scheduled to run every 10 minutes (can stretch to 40
minutes depending on executor availability though), and in the first runs after
INFRA-16194 was done, two Lucene/Solr issues qualified ("Patch Available"
status and updated some time in the last 2 weeks) were submitted: LUCENE-8197
and SOLR-11331. Unfortunately, I had not properly configured the auth token on
the {{PreCommit-\{LUCENE,SOLR\}-Build}} jobs -- {{PreCommit-Admin}} always
supplies token 'hadoopqa' when it triggers all {{PreCommit-\*}} jobs, and I had
configured the jobs to expect 'lucenesolrqa'; I've since fixed this -- and as a
result the builds didn't kick off, but {{PreCommit-Admin}}'s database of
submitted patches now includes the attachments that were submitted as already
dealt with, so those patches won't be validated until somebody uploads new
patches there.
I re-opened and switched status to "Patch Available" on the two test issues I
created to manually test the new {{PreCommit}} jobs (LUCENE-8210 and
SOLR-12106). {{PreCommit-Admin}} has now run again and has queued the
corresponding {{PreCommit}} jobs to validate the patches on those two issues
(once they run the results will be available at
[https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-LUCENE-Build/10/]
and
[https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-SOLR-Build/6/]).
> Adding automatic patch validation
> ---------------------------------
>
> Key: SOLR-10912
> URL: https://issues.apache.org/jira/browse/SOLR-10912
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build
> Reporter: Mano Kovacs
> Assignee: Steve Rowe
> Priority: Major
> Attachments: SOLR-10912.ok-patch-in-core.patch, SOLR-10912.patch,
> SOLR-10912.patch, SOLR-10912.sample-patch.patch,
> SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or
> other Apache projects are using (see link). This would ensure that every
> patch passes a certain set of criterions before getting approved. It would
> save time for developer (faster feedback loop), save time for committers
> (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be
> a good direction to start. This jira could be the board of discussing the
> preferred solution.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
