[
https://issues.apache.org/jira/browse/LUCENE-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404095#comment-16404095
]
Simon Willnauer commented on LUCENE-8206:
-----------------------------------------
ah bummer I was just reviewing it. I think it LGTM mostly. I'd just throw
AssertionError instead of wrapping it in a RT exception if the barrier barfs.
There is also a _Thread.sleep(100);_ in there that I would love to see gone
maybe replace it with a yield()? thanks for taking care of it.
> TestIndexWriterWithThreads has wall-clock time dependency
> ---------------------------------------------------------
>
> Key: LUCENE-8206
> URL: https://issues.apache.org/jira/browse/LUCENE-8206
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: master (8.0)
>
> Attachments: LUCENE-8206.patch
>
>
> {code}
> final long stopTime = System.currentTimeMillis() + 200;
> {code}
> This can cause failures on slower machines.
> {code}
> Build: https://builds.apache.org/job/Lucene-Solr-Tests-master/2422/
> 3 tests failed.
> FAILED:
> org.apache.lucene.index.TestIndexWriterWithThreads.testCloseWithThreads
> Error Message:
> thread failed before indexing a single document
> Stack Trace:
> java.lang.AssertionError: thread failed before indexing a single document
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
