[
https://issues.apache.org/jira/browse/LUCENE-6425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405244#comment-16405244
]
Dean Gurvitz commented on LUCENE-6425:
--------------------------------------
I was wondering how an explicit API change took place in a minor Lucene
version? With no deprecation warnings or anything of that kind coming first. I
recently upgraded a minor version of Lucene and was very surprised when things
stopped compiling.
Plus, it seems to me that the solution offered by Adrien for getting non index
dependent terms is very messy and inelegant compared to the previous situation.
Is there no way to change this?
> Move extractTerms to Weight
> ---------------------------
>
> Key: LUCENE-6425
> URL: https://issues.apache.org/jira/browse/LUCENE-6425
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 5.2, 6.0
>
> Attachments: LUCENE-6425.patch, LUCENE-6425.patch
>
>
> Today we have extractTerms on Query, but it is supposed to only be called
> after the query has been specialized to a given IndexReader using
> Query.rewrite(IndexReader) to allow some complex queries to replace terms
> "matchers" with actual terms (eg. WildcardQuery).
> However, we already have an abstraction for indexreader-specialized queries:
> Weight. So I think it would make more sense to have extractTerms on Weight.
> This would also remove the trap of calling extractTerms on a query which is
> not rewritten yet.
> Since Weights know about whether scores are needed or not, I also hope this
> would help improve the extractTerms semantics. We currently have 2 use-cases
> for extractTerms: distributed IDF and highlighting. While the former only
> cares about terms which are used for scoring, it could make sense to
> highlight terms that were used for matching, even if they did not contribute
> to the score (eg. if wrapped in a ConstantScoreQuery or a BooleanQuery FILTER
> clause). So highlighters could do searcher.createNormalizedWeight(query,
> false).extractTerms(termSet) to get all terms that were used for matching the
> query while distributed IDF would instead do
> searcher.createNormalizedWeight(query, true).extractTerms(termSet) to get
> scoring terms only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
