[ 
https://issues.apache.org/jira/browse/LUCENE-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405456#comment-16405456
 ] 

ASF subversion and git services commented on LUCENE-8212:
---------------------------------------------------------

Commit 65559cb94d2cbbc9081f6f5d6d8f6bac055b11e6 in lucene-solr's branch 
refs/heads/master from [~simonw]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=65559cb ]

LUCENE-8212: Make sure terms hash is always closed

if stored fields writer barfs we still need to close terms hash to
close pending files. This is crucial for some tests like 
TestIndexWriterOnVMError
that randomly failed due to this.


>  Never swallow Exceptions in IndexWriter and DocumentsWriter
> ------------------------------------------------------------
>
>                 Key: LUCENE-8212
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8212
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Simon Willnauer
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>
>         Attachments: LUCENE-8212.patch, LUCENE-8212.patch
>
>
>  IndexWriter as well as DocumentsWriter caught Throwable and ignored it. This 
> is mainly a relict from pre Java 7 were exceptions didn't have the needed API 
> to suppress exceptions. This change handles exceptions correctly where the 
> original exception is rethrown and all other exceptions are added as 
> suppressed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to